Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devnet): pop api + fungibles use case #132

Merged
merged 66 commits into from
Sep 13, 2024
Merged

feat(devnet): pop api + fungibles use case #132

merged 66 commits into from
Sep 13, 2024

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Jul 26, 2024 •
edited
Loading

Pop API + local fungibles implementation (minus native token)

Closes #65

Size of contract pop-api/examples/fungibles/ compared to the psp22 extension in ink-examples:

  • Fungibles contract:
    Original wasm size: 31.3K, Optimized: 7.4K (current IT contract is bigger because there are more functions implemented)
  • Template contract:
    Original wasm size: 30.3K, Optimized: 7.0K

Contains:

Merged after

Daanvdplas and others added 29 commits May 19, 2024 17:38
@Daanvdplas
feat: pallet assets pop api integration
7c2eac2
@Daanvdplas
style: renaming assets example
418aa63
@Daanvdplas
refactor: chain extension tests
3d385df
@Daanvdplas
fix: add error handling other than ModuleError
fd46a27
@Daanvdplas
test: add transfer
1022926
@Daanvdplas
chore: remove polkadot launch
ecc82e2
@Daanvdplas
# This is a combination of 8 commits.
e81f78a 
# This is the 1st commit message:

refactor: general

# This is the commit message #2:

init

# This is the commit message #3:

begin refactor

# This is the commit message #4:

refactor: error handling

# This is the commit message #5:

tests: add error handling tests

# This is the commit message #6:

WIP

# This is the commit message #7:

finalise error handling

# This is the commit message #8:

refactor: easier review
@Daanvdplas
refactor: error handling
f824801
@Daanvdplas
refactor: clarify todos
4670503
@Daanvdplas
refactor: error handling comments part 1
2283161
@Daanvdplas
refactor: apply comments part 2
f88dd89
@Daanvdplas
refactor: tests local fungibles
61b3a17
@Daanvdplas
refactor: naming pallet error
c1616a3
@Daanvdplas
refactor: optimising pop api and additional logic + test
13e947e
@Daanvdplas
refactor: runtime
7757319
@Daanvdplas
refactor: draft final design
924df85
@Daanvdplas
feat: add more interfaces
972e4c9
@Daanvdplas
refactor: final bits
47e2ea6
@Daanvdplas
fix: compiling
9dcfccb
@Daanvdplas
fix: cannot find macro vec error
b067eda
@Daanvdplas
refactor: decoding failed and commenting out unimplemented tests
8730f90
@Daanvdplas
style: renaming
b591222
@Daanvdplas
refactor: bits and pieces
c2acbb5
@Daanvdplas
docs: add docs to code
3639320
@Daanvdplas
fix: replace test code to api fungibles
81e9844
@Daanvdplas
fix: own review + fixing CI fail
023d3dc
@Daanvdplas
refactor: add Error variants index + clippy allowance
e683e16
@Daanvdplas @evilrobot-01
feat: api fungibles pallet (#113)
28d971b 
Co-authored-by: Frank Bell <[email protected]>
@chungquantin
refactor: streamline error from the decoded method by returning `Resu…
4e4512e 
…lt` (#130)
@Daanvdplas Daanvdplas mentioned this pull request Jul 26, 2024
Closed
16 tasks
@evilrobot-01
Merge branch 'refs/heads/main' into daan/api
114934a 
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	pop-api/Cargo.toml
#	primitives/Cargo.toml
#	primitives/src/lib.rs
#	primitives/src/storage_keys.rs
#	runtime/devnet/Cargo.toml
#	runtime/devnet/src/config/assets.rs
#	runtime/devnet/src/config/contracts.rs
#	runtime/devnet/src/extensions.rs
#	runtime/devnet/src/lib.rs
#	runtime/testnet/Cargo.toml
#	runtime/testnet/src/config/assets.rs
@evilrobot-01
chore: resolve merge issues
d7cba0a
@evilrobot-01
ci: clear more space
a272657 
Required due to failure or coverage CI job.
@evilrobot-01
ci: disable debug info for coverage
c0ea3ed 
Required due to failure or coverage CI job.
@evilrobot-01
Copy link
Collaborator

Coverage at https://app.codecov.io/github/r0gue-io/pop-node/pull/132/

@Daanvdplas @chungquantin @evilrobot-01
style: token terminology (#215)
206757b 
Co-authored-by: Tin Chung <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
evilrobot-01
evilrobot-01 requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran out of steam on pop-api/integration-tests/src/fungibles/mod.rs and marked accordingly - 7k lines just too much. All other files reviewed.

pallets/api/src/extension.rs Outdated Show resolved Hide resolved
pallets/api/src/extension.rs Outdated Show resolved Hide resolved
pallets/api/src/extension.rs Outdated Show resolved Hide resolved
pallets/api/src/extension.rs Show resolved Hide resolved
pallets/api/src/mock.rs Outdated Show resolved Hide resolved
primitives/src/lib.rs Outdated Show resolved Hide resolved
primitives/src/lib.rs Show resolved Hide resolved
runtime/devnet/src/config/api/mod.rs Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
runtime/devnet/src/config/api/versioning.rs Outdated Show resolved Hide resolved
peterwht
peterwht reviewed Sep 11, 2024
View reviewed changes
pallets/api/src/extension.rs Outdated Show resolved Hide resolved
pop-api/integration-tests/src/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/integration-tests/src/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/integration-tests/src/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/integration-tests/src/fungibles/mod.rs Outdated Show resolved Hide resolved
pop-api/integration-tests/src/fungibles/mod.rs Show resolved Hide resolved
pop-api/src/lib.rs Outdated Show resolved Hide resolved
pop-api/src/lib.rs Outdated Show resolved Hide resolved
pop-api/src/lib.rs Outdated Show resolved Hide resolved
primitives/src/lib.rs Show resolved Hide resolved
This was referenced Sep 11, 2024
Merged
Closed
Open
@Daanvdplas Daanvdplas mentioned this pull request Sep 13, 2024
Merged
Daanvdplas and others added 6 commits September 13, 2024 16:50
@Daanvdplas
refactor: api integration tests (#280)
7bbc04c
@peterwht
feat(pallet-api/fungibles): benchmark read functions (#284)
5f92dab
@Daanvdplas @evilrobot-01 @peterwht
test(devnet): runtime api (#274)
4b9da05 
Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Peter White <[email protected]>
@Daanvdplas @evilrobot-01
test: pallet api fungibles (#278)
a81c8b4 
Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
@chungquantin @Daanvdplas @peterwht
test: assert events emitted from contract (#216)
bf27640 
Co-authored-by: Daanvdplas <[email protected]>
Co-authored-by: Peter White <[email protected]>
@chungquantin @Daanvdplas
@evilrobot-01 @peterwht
refactor: api event naming conventions (#286)
7aa4447 
Co-authored-by: Daanvdplas <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Frank Bell <[email protected]>
Co-authored-by: Peter White <[email protected]>
@peterwht peterwht mentioned this pull request Sep 13, 2024
Open
@peterwht peterwht mentioned this pull request Sep 13, 2024
Open
evilrobot-01
evilrobot-01 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@peterwht peterwht merged commit b653091 into main Sep 13, 2024
9 of 10 checks passed
@peterwht peterwht deleted the daan/api branch September 13, 2024 20:18
This was referenced Oct 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilrobot-01 evilrobot-01 evilrobot-01 approved these changes

@peterwht peterwht peterwht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: local fungibles pop api integration
5 participants
@Daanvdplas @codecov-commenter @evilrobot-01 @chungquantin @peterwht